-
-
Notifications
You must be signed in to change notification settings - Fork 10
-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review of public Ref(external count, Thread.Yield, error return) #8
Comments
Found similar code in .NET source
|
I guess throw via Thrower may save some performance of spin. Could check that. Example is jtmueller/Collections.Pooled#8 |
These people are not afraid of timeout https://github.com/scalaz/scalaz-zio/blob/master/core/shared/src/main/scala/scalaz/zio/Ref.scala#L42. And use function. May be this Ref should to. |
Another |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Did some view onto, hope you find some useful.
ImTools/src/ImTools/ImTools.cs
Line 534 in 56b7f53
Also it is public, it may deliver some caveats to possible users:
ImTools/src/ImTools.UnitTests/RefTests.cs
Line 7 in 56b7f53
ImTools/src/ImTools/ImTools.cs
Line 524 in 56b7f53
ImTools/src/ImTools/ImTools.cs
Line 489 in 56b7f53
reference equals
instead ofequals
(to be crystal clear).ImTools/src/ImTools/ImTools.cs
Line 497 in 56b7f53
ImTools/src/ImTools/ImTools.cs
Line 498 in 56b7f53
==
https://docs.microsoft.com/en-us/dotnet/csharp/language-reference/operators/equality-comparison-operator. Same seems hereImTools/src/ImTools/ImTools.cs
Line 531 in 56b7f53
The text was updated successfully, but these errors were encountered: