Cython binding for slice, head and tail #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arup Sarker <arupcsedu@gmail.com>
Signed-off-by: Arup Sarker <arupcsedu@gmail.com>
Signed-off-by: Arup Sarker <arupcsedu@gmail.com>
Signed-off-by: Arup Sarker <arupcsedu@gmail.com>
Closed
vibhatha
reviewed
Sep 16, 2022
vibhatha
reviewed
Sep 16, 2022
vibhatha
reviewed
Sep 16, 2022
vibhatha
reviewed
Sep 16, 2022
vibhatha
reviewed
Sep 16, 2022
vibhatha
reviewed
Sep 16, 2022
vibhatha
reviewed
Sep 16, 2022
vibhatha
reviewed
Sep 16, 2022
vibhatha
reviewed
Sep 16, 2022
vibhatha
reviewed
Sep 16, 2022
vibhatha
requested changes
Sep 16, 2022
Signed-off-by: Arup Sarker <arupcsedu@gmail.com>
vibhatha
reviewed
Sep 19, 2022
vibhatha
reviewed
Sep 19, 2022
vibhatha
reviewed
Sep 19, 2022
vibhatha
reviewed
Sep 19, 2022
vibhatha
reviewed
Sep 19, 2022
vibhatha
reviewed
Sep 19, 2022
vibhatha
reviewed
Sep 19, 2022
|
@arupcsedu whats the status of this PR? 🙂 |
|
Hi Niranda, I will submit by today. Sorry for later
…On Wed, 28 Sep, 2022 at 11:23 AM, niranda perera ***@***.***> wrote:
@arupcsedu <https://github.com/arupcsedu> whats the status of this PR? 🙂
—
Reply to this email directly, view it on GitHub
<#619 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACOGXWU4RKRS47UHZFHXRPLWARPHNANCNFSM6AAAAAAQJPAKUU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@nirandaperera and @vibhatha , I have submitted the new changes. |
Signed-off-by: Arup Sarker <arupcsedu@gmail.com>
Please fix the branch conflict. Otherwise we wont be able to run the CI jobs. |
|
@
@nirandaperera , Fixed and commited. |
Signed-off-by: Arup Sarker <arupcsedu@gmail.com>
vibhatha
approved these changes
Sep 30, 2022
|
Merged. @arupcsedu thank you for taking this up & @vibhatha thank you for reviewing this. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. add cython bindings
2. Update getitem method in pycylon.DataFrame. For distributed head/ tail/ slice, pass an additional CylonEnv object to getitem method
Examples:
df = ....
df[5:100] # local slice
df[:5] # local head
df[:-5] # local tail
df[5:100, env] # distributed slice
df[:5, env] # distributed head
df[:-5, env] # distributed tail
3. add python test
Issues: #317
Reference - Design doc
https://docs.google.com/document/d/1wQ3rVj5OBLXju5hf6FWlwyDGc65ync_LZVQ_QzsHX-c/edit
Reference GPU impl #512