Fix Georgian localization #44
Conversation
mpkorstanje
force-pushed
the
fix-georgian-localisation
branch
from
1f5d8e9
to
bbd7d0e
Compare
|
@avsd Did I guess this translation correctly? βοΈ |
In cucumber/common#2041 only half a unicode glyph was pasted to create `α²ααͺααα£ααα `. This half glyph breaks code generation in other projects, e.g: https://github.com/cucumber/cucumber-jvm/actions/runs/3429109517/jobs/5714282373 This presumably (based on some searching) should have been `αααͺααα£ααα`.Though I don't speak Georgian. Please send another pull request if this is not correct.
mpkorstanje
force-pushed
the
fix-georgian-localisation
branch
from
bbd7d0e
to
eab7b34
Compare
Visually it looks exactly the same! I'm wondering how could I have lost half a glyph :D - and how could it have been rendered correctly with half a glyph lost? Sorry for that! |
|
@mpkorstanje, ok, I know the answer. It contained CAPITAL letter (not used in modern Georgian): https://www.compart.com/en/unicode/U+1C9B instead of a correct SMALL letter: https://www.compart.com/en/unicode/U+10DB Possible reason why it might have happened is capitalization, which is probably performed by some script when generating the files. If that's the case, it may happen again
|
|
ok, apparently it was introduced by me, during the very initial commit: cucumber/common@7054aa5 Maybe because I was using some unusual IDE (either Mac's TextEdit or GitHub's built-in editor) that did auto-capitalization after hitting "space". But the problem is that this incorrect "Georgian Capital Letter M" might have been spread to numerous repositories, all of them requiring a fix. What's the best way to do it, @mpkorstanje ? |
|
I don't think anything has to be done. I've just extracted The mistake is duplicated in a few other repositories but those are subtrees of What has been released will have a patch version to fix it. |
|
Ok, good! :) In that case, here are two more locations this letter appeared: #45 |
π€ What's changed?
In cucumber/common#2041 only half a unicode glyph was pasted to create
α²ααͺααα£ααα. This half glyph breaks code generation in other projects, e.g:https://github.com/cucumber/cucumber-jvm/actions/runs/3429109517/jobs/5714282373
This presumably (based on some searching) should have been
αααͺααα£ααα.Though I don't speak Georgian. Please send another pull request if this is not correct.π Checklist: