Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate token matcher Python code #205

Merged
merged 4 commits into from
Jan 4, 2024

Conversation

kieran-ryan
Copy link
Sponsor Member

@kieran-ryan kieran-ryan commented Jan 1, 2024

🤔 What's changed?

Change Python implementation of markdown token matcher to inherit from feature file token matcher.

⚡️ What's your motivation?

  • Remove duplicated code - ensuring a source of truth and improved maintainability.
  • Add missing entry in manifest for markdown token matcher - added automatically as part of build process when running test suite through tox

Existing test suite remained compatible for the feature file and markdown matchers after the change - including with Python 2.

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, documentation etc. without changing behaviour)

♻️ Anything particular you want feedback on?

NA.

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

@kieran-ryan kieran-ryan self-assigned this Jan 1, 2024
@kieran-ryan kieran-ryan marked this pull request as ready for review January 1, 2024 19:44
@mpkorstanje mpkorstanje merged commit 26b0f70 into cucumber:main Jan 4, 2024
4 checks passed
@mpkorstanje
Copy link
Contributor

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants