Preserve trailing comments. Fixes #38. #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also eliminate useless trailing space after `:` when the node has no `name`.
xeger
force-pushed
the
trailingComments
branch
from
21001f2
to
1153006
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
This fixes the bug described in #38.
⚡️ What's your motivation?
Comments still aren't handled ideally; see #40 for some remaining issues. However, this bug is "destructive" i.e. the formatter can remove Gherkin statements that have been temporarily commented out.
It's better to fix the destructive bug quickly than to strive for perfection. We can discuss future refinements on #40.
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
📋 Checklist: