Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gherkin: compile empty scenarios to empty pickles #264

Merged
merged 9 commits into from
Oct 6, 2017

Conversation

brasmusson
Copy link
Contributor

@brasmusson brasmusson commented Aug 31, 2017

Summary

Compile scenarios with no steps to pickles with no steps.

Details

For scenario outlines with no steps, one pickle with no steps is compiled for each example table body row.

For scenario outlines with neither steps nor example table body rows, no pickle is created

Updated language versions:

  • c
  • .NET
  • go
  • java
  • javascript
  • pearl
  • python
  • objective-c (there is not pickles compiler in the objective-c version)
  • ruby

Motivation and Context

Fixes cucumber/gherkin#11.

How Has This Been Tested?

The acceptance testdata has been updated.

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • I've added tests for my code.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@brasmusson brasmusson added library: gherkin ⚡ enhancement Request for new functionality labels Sep 1, 2017
@brasmusson brasmusson force-pushed the empty-pickle-for-empty-scenario branch from 077c48e to 800739f Compare September 2, 2017 18:41
@aslakhellesoy aslakhellesoy merged commit a7df554 into master Oct 6, 2017
aslakhellesoy added a commit that referenced this pull request Oct 6, 2017
@aslakhellesoy aslakhellesoy deleted the empty-pickle-for-empty-scenario branch July 12, 2018 21:12
@lock
Copy link

lock bot commented Jul 12, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
library: gherkin ⚡ enhancement Request for new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gherkin: Compiling empty scenarios
3 participants