Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n: Georgian (ka) localization fixes #2041

Merged
merged 9 commits into from
Nov 2, 2022
Merged

Conversation

avsd
Copy link
Contributor

@avsd avsd commented Jul 14, 2022

Summary

Details

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • The change has been ported to Java.
  • The change has been ported to Ruby.
  • The change has been ported to JavaScript.
  • The change has been ported to Go.
  • The change has been ported to .NET.
  • The change has been ported to Perl.
  • I've added tests for my code.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have updated the CHANGELOG accordingly.

Copy link
Contributor

@aurelien-reeves aurelien-reeves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this is good 😅

@luke-hill luke-hill enabled auto-merge (squash) July 26, 2022 10:01
@mpkorstanje
Copy link
Contributor

image

Oooof.

@mpkorstanje mpkorstanje self-assigned this Nov 2, 2022
@luke-hill
Copy link
Contributor

Evidently it took a while to hit the requirements haha :D

@mpkorstanje mpkorstanje enabled auto-merge (squash) November 2, 2022 16:29
@mpkorstanje mpkorstanje merged commit 26c9d37 into cucumber:main Nov 2, 2022
@aslakhellesoy
Copy link
Contributor

Hi @avsd,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

  • ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
  • 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
  • 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
  • ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
  • 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

mpkorstanje added a commit to cucumber/gherkin that referenced this pull request Nov 9, 2022
In cucumber/common#2041 only half a unicode glyph was
pasted to create `Მოცემულია `. This half glyph breaks code generation in other
projects, e.g:

https://github.com/cucumber/cucumber-jvm/actions/runs/3429109517/jobs/5714282373

This presumably (based on some searching) should have been `მოცემულია`.Though
I don't speak Georgian. Please send another pull request if this is not
correct.
mpkorstanje added a commit to cucumber/gherkin that referenced this pull request Nov 9, 2022
In cucumber/common#2041 only half a unicode glyph was
pasted to create `Მოცემულია `. This half glyph breaks code generation in other
projects, e.g:

https://github.com/cucumber/cucumber-jvm/actions/runs/3429109517/jobs/5714282373

This presumably (based on some searching) should have been `მოცემულია`.Though
I don't speak Georgian. Please send another pull request if this is not
correct.
mpkorstanje added a commit to cucumber/gherkin that referenced this pull request Nov 9, 2022
In cucumber/common#2041 only half a unicode glyph was
pasted to create `Მოცემულია `. This half glyph breaks code generation in other
projects, e.g:

https://github.com/cucumber/cucumber-jvm/actions/runs/3429109517/jobs/5714282373

This presumably (based on some searching) should have been `მოცემულია`.Though
I don't speak Georgian. Please send another pull request if this is not
correct.
mpkorstanje added a commit to cucumber/gherkin that referenced this pull request Nov 9, 2022
In cucumber/common#2041 only half a unicode glyph was
pasted to create `Მოცემულია `. This half glyph breaks code generation in other
projects, e.g:

https://github.com/cucumber/cucumber-jvm/actions/runs/3429109517/jobs/5714282373

This presumably (based on some searching) should have been `მოცემულია`. Though
I don't speak Georgian. Please send another pull request if this is not
correct.
cukebot pushed a commit to cucumber/gherkin-go that referenced this pull request Nov 9, 2022
In cucumber/common#2041 only half a unicode glyph was
pasted to create `Მოცემულია `. This half glyph breaks code generation in other
projects, e.g:

https://github.com/cucumber/cucumber-jvm/actions/runs/3429109517/jobs/5714282373

This presumably (based on some searching) should have been `მოცემულია`. Though
I don't speak Georgian. Please send another pull request if this is not
correct.
cukebot pushed a commit to cucumber/gherkin-php that referenced this pull request Nov 9, 2022
In cucumber/common#2041 only half a unicode glyph was
pasted to create `Მოცემულია `. This half glyph breaks code generation in other
projects, e.g:

https://github.com/cucumber/cucumber-jvm/actions/runs/3429109517/jobs/5714282373

This presumably (based on some searching) should have been `მოცემულია`. Though
I don't speak Georgian. Please send another pull request if this is not
correct.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants