Expand the messages protocol with keyword types (extracted from #1741) #1966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extracted from #1741 for ease of review on request of @aurelien-reeves, implements the `messages` side of #768.
ehuelsmann
requested review from
aslakhellesoy,
ciaranmcnulty and
aurelien-reeves
|
This breaks the Java build, because the GherkinDocumentBuilder argument list changed in length due to this change. |
There was a problem hiding this comment.
Looks good, thanks @ehuelsmann 👍
I don't quiet get the issue with java. @mpkorstanje @aslakhellesoy could you take a look?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Extracted from #1741 for ease of review on request of @aurelien-reeves,
implements the
messagesside of #768.Details
This PR paves the way for #1741, realizing the first step of the required infrastructure: being able to marshall the required info over the protocol, with library support for all languages in which
messagescurrently is implemented.Motivation and Context
SpecFlow and Pherkin require this support in order to be able to switch to the Cucumber community maintained parser and pickle generator.
How Has This Been Tested?
By the CI pipeline.
Screenshots (if appropriate):
Types of changes
Checklist:
The change has been ported to .NET.We agreed this isn't necessary