Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gherkin-languages: add US-Texan localisation #1625

Merged
merged 7 commits into from
Jul 7, 2021

Conversation

willmac321
Copy link
Contributor

@willmac321 willmac321 commented Jun 22, 2021

Add an en-tx (US Texan) localisation :) Thank's y'all!

Summary

Add a US Texan localization to gherkin-languages.json

Motivation and Context

Regarding the question about solving, it makes it so I can understand y'all better! Also for the memes.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • The change has been ported to Java.
  • The change has been ported to Ruby.
  • The change has been ported to JavaScript.
  • The change has been ported to Go.
  • The change has been ported to .NET.
  • I've added tests for my code.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have updated the CHANGELOG accordingly.

Add an en-tx (US Texan) localisation :)  Thank's y'all!
@willmac321 willmac321 changed the title gherkin-languages: add US-Texan localisation Draft: gherkin-languages: add US-Texan localisation Jun 22, 2021
@aslakhellesoy
Copy link
Contributor

Lovely! Did you know we used to have a Texan translation at some point contributed by an idiot?

cucumber-attic/gherkin2@0e9322a

@willmac321
Copy link
Contributor Author

willmac321 commented Jun 23, 2021 via email

@willmac321 willmac321 changed the title Draft: gherkin-languages: add US-Texan localisation gherkin-languages: add US-Texan localisation Jun 23, 2021
@mattwynne
Copy link
Member

I need to see a full example of a scenario using this language! 😀

@willmac321
Copy link
Contributor Author

I need to see a full example of a scenario using this language! 😀

Haha, I'll try to get this for y'all! I need to run through y'all's checklist still. :D

@aurelien-reeves aurelien-reeves added ⚡ enhancement Request for new functionality library: gherkin labels Jun 28, 2021
@aurelien-reeves aurelien-reeves merged commit c611754 into cucumber:main Jul 7, 2021
@aslakhellesoy
Copy link
Contributor

Hi @willmac321,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

  • ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
  • 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
  • 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
  • ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
  • 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

@willmac321 willmac321 deleted the patch-1 branch July 16, 2021 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
library: gherkin ⚡ enhancement Request for new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants