Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve spec isolation by not blanket-including Aruba #547

Merged
merged 1 commit into from
Mar 6, 2018

Conversation

mvz
Copy link
Contributor

@mvz mvz commented Mar 6, 2018

Summary

Improve spec isolation by not blanket-including Aruba

Details

Don't do include Aruba in the spec helper.

Motivation and Context

Less confusion in specs between modules and methods provided by the test environment and Ruby on the one hand, and Aruba on the other. Mainly just a back-port of a fix that's already on master.

How Has This Been Tested?

Travis.

Types of changes

  • Refactoring (cleanup of code base without changing any existing functionality)

Copy link
Contributor

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement.

@mvz mvz merged commit eb62845 into still Mar 6, 2018
@mvz mvz deleted the improve-spec-isolation-still branch March 6, 2018 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants