Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rakefile: wrap in bundle exec #447

Merged
merged 1 commit into from
Jul 10, 2017
Merged

Rakefile: wrap in bundle exec #447

merged 1 commit into from
Jul 10, 2017

Conversation

olleolleolle
Copy link
Contributor

  • I am trying to make the Travis build run license_finder

  - I am trying to make the Travis build run license_finder
@maxmeyer maxmeyer merged commit cb97936 into master Jul 10, 2017
@olleolleolle olleolleolle deleted the fix/license_finder-to-run branch July 10, 2017 20:04
@olleolleolle
Copy link
Contributor Author

@maxmeyer Oh, my investigation was not final - and the license_finder still fails in Travis, trying to locate the right gems in the Gemfile.lock - https://travis-ci.org/cucumber/aruba/jobs/252143170#L340 is an example of that.

@maxmeyer
Copy link
Member

maxmeyer commented Jul 10, 2017

There's another PR fixing a lot of issues from @mvz, #434.

@olleolleolle
Copy link
Contributor Author

@maxmeyer Thanks for linking to that! It explains so much

@mvz
Copy link
Contributor

mvz commented Jul 11, 2017

This commit shouldn't be needed since AIUI, all bundle exec does is set some environment variables, and these will already be inherited from the outer level bundle exec rake.

@maxmeyer
Copy link
Member

maxmeyer commented Jul 11, 2017

@mvz You're right, I think that was the reason, why I didn't add it. but it doesn't do any harm for those using rake directly, right?

@mvz
Copy link
Contributor

mvz commented Jul 11, 2017

No, I don't think it does any harm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants