Skip to content
This repository has been archived by the owner on Apr 9, 2020. It is now read-only.

Broken preview for SVG files missing XML namespace #55

Open
sovietspaceship2 opened this issue Apr 9, 2019 · 1 comment
Open

Broken preview for SVG files missing XML namespace #55

sovietspaceship2 opened this issue Apr 9, 2019 · 1 comment

Comments

@sovietspaceship2
Copy link

sovietspaceship2 commented Apr 9, 2019

Previewing some svg file results in this:

Screen Shot 2019-04-09 at 12 36 16

Screen Shot 2019-04-09 at 12 38 57

which points to /media/preview.js:16

Code version: 1.32.3, clean install, on macOS
Extension version: 2.0.0 from marketplace

@sovietspaceship2
Copy link
Author

sovietspaceship2 commented Apr 9, 2019

Seems to only happen with svg files missing xmlns="http://www.w3.org/2000/svg", which is not required when svg is parsed as html (https://www.w3.org/TR/SVG2/struct.html#Namespace).

(My usecase is svg files meant to be used as html template fragments, which may be outside of the scope of this extension, workaround is just adding the required attribute to all svg files)

@sovietspaceship2 sovietspaceship2 changed the title Broken preview - Uncaught TypeError: Cannot read property 'addEventListener' of null Broken preview for SVG files missing XML namespace Apr 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant