From b29ffa3a566be366a5b566879e6aa086110c619e Mon Sep 17 00:00:00 2001 From: Gianmaria Del Monte Date: Thu, 11 Nov 2021 11:45:53 +0100 Subject: [PATCH 1/2] Fix nil pointer exception when resolving members of a group --- pkg/cbox/group/rest/rest.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/pkg/cbox/group/rest/rest.go b/pkg/cbox/group/rest/rest.go index 2e93809d60..439ec9c6c9 100644 --- a/pkg/cbox/group/rest/rest.go +++ b/pkg/cbox/group/rest/rest.go @@ -346,7 +346,9 @@ func (m *manager) GetMembers(ctx context.Context, gid *grouppb.GroupId) ([]*user if !ok { return nil, errors.New("rest: error in type assertion") } - users = append(users, &userpb.UserId{OpaqueId: userInfo["upn"].(string), Idp: m.conf.IDProvider}) + if id, ok := userInfo["upn"].(string); ok { + users = append(users, &userpb.UserId{OpaqueId: id, Idp: m.conf.IDProvider}) + } } if err = m.cacheGroupMembers(gid, users); err != nil { From 3447b0c4d2a1729db435c6cb1f444a425be4e7d7 Mon Sep 17 00:00:00 2001 From: Gianmaria Del Monte Date: Thu, 11 Nov 2021 11:47:59 +0100 Subject: [PATCH 2/2] Add changelog --- changelog/unreleased/fix-nil-exception-groups.md | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 changelog/unreleased/fix-nil-exception-groups.md diff --git a/changelog/unreleased/fix-nil-exception-groups.md b/changelog/unreleased/fix-nil-exception-groups.md new file mode 100644 index 0000000000..5c773e529f --- /dev/null +++ b/changelog/unreleased/fix-nil-exception-groups.md @@ -0,0 +1,3 @@ +Bugfix: Fix nil pointer exception when resolving members of a group (rest driver) + +https://github.com/cs3org/reva/pull/2265 \ No newline at end of file