From a955d6269826c09ee5205bda09e65e69449b57b4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=B6rn=20Friedrich=20Dreyer?= Date: Thu, 20 Jan 2022 13:03:48 +0100 Subject: [PATCH] decomposedfs: do not swallow errors when creating nodes (#2457) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Jörn Friedrich Dreyer --- changelog/unreleased/do-not-swallow-error.md | 5 +++++ pkg/storage/utils/decomposedfs/tree/tree.go | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) create mode 100644 changelog/unreleased/do-not-swallow-error.md diff --git a/changelog/unreleased/do-not-swallow-error.md b/changelog/unreleased/do-not-swallow-error.md new file mode 100644 index 00000000000..f8c094847b1 --- /dev/null +++ b/changelog/unreleased/do-not-swallow-error.md @@ -0,0 +1,5 @@ +Bugfix: do not swallow error + +decomposedfs not longer swallows errors when creating a node fails. + +https://github.com/cs3org/reva/pull/2457 \ No newline at end of file diff --git a/pkg/storage/utils/decomposedfs/tree/tree.go b/pkg/storage/utils/decomposedfs/tree/tree.go index 83abd3e7dcb..a1c0b275835 100644 --- a/pkg/storage/utils/decomposedfs/tree/tree.go +++ b/pkg/storage/utils/decomposedfs/tree/tree.go @@ -259,7 +259,7 @@ func (t *Tree) CreateDir(ctx context.Context, n *node.Node) (err error) { err = t.createNode(n, owner) if err != nil { - return nil + return } // make child appear in listings