diff --git a/internal/http/services/owncloud/ocs/conversions/role.go b/internal/http/services/owncloud/ocs/conversions/role.go index d7caa228f1d..c5a3fc7d3ed 100644 --- a/internal/http/services/owncloud/ocs/conversions/role.go +++ b/internal/http/services/owncloud/ocs/conversions/role.go @@ -280,7 +280,7 @@ func RoleFromOCSPermissions(p Permissions) *Role { role := "" if p.Contain(PermissionRead) { role = RoleViewer - if p.Contain(PermissionWrite | PermissionCreate | PermissionDelete) { + if p.Contain(PermissionWrite) && p.Contain(PermissionCreate) && p.Contain(PermissionDelete) { role = RoleEditor if p.Contain(PermissionShare) { role = RoleCoowner @@ -374,7 +374,7 @@ func RoleFromResourcePermissions(rp *provider.ResourcePermissions) *Role { r.ocsPermissions = r.ocsPermissions | PermissionShare } if r.ocsPermissions.Contain(PermissionRead) { - if r.ocsPermissions.Contain(PermissionWrite | PermissionCreate | PermissionDelete) { + if r.ocsPermissions.Contain(PermissionWrite) && r.ocsPermissions.Contain(PermissionCreate) && r.ocsPermissions.Contain(PermissionDelete) { r.Name = RoleEditor if r.ocsPermissions.Contain(PermissionShare) { r.Name = RoleCoowner diff --git a/internal/http/services/owncloud/ocs/handlers/apps/sharing/shares/shares.go b/internal/http/services/owncloud/ocs/handlers/apps/sharing/shares/shares.go index 4a7628ebc2d..c0d386569ca 100644 --- a/internal/http/services/owncloud/ocs/handlers/apps/sharing/shares/shares.go +++ b/internal/http/services/owncloud/ocs/handlers/apps/sharing/shares/shares.go @@ -153,7 +153,7 @@ func (h *Handler) createShare(w http.ResponseWriter, r *http.Request) { response.WriteOCSError(w, r, response.MetaBadRequest.StatusCode, "shareType must be an integer", nil) return } - // TODO get user permissions on the shared file + // get user permissions on the shared file c, err := pool.GetGatewayServiceClient(h.gatewayAddr) if err != nil {