From 6a598b8af4f899426c2c45c8eb126fa094847cf4 Mon Sep 17 00:00:00 2001 From: kobergj Date: Tue, 15 Mar 2022 14:13:31 +0100 Subject: [PATCH] Delay reconnect log (#2636) * delay logging of reconnect msg to 1 second Signed-off-by: jkoberg * add changelog Signed-off-by: jkoberg * address TODO Signed-off-by: jkoberg --- changelog/unreleased/delay-reconnect-log.md | 5 +++++ pkg/events/server/nats.go | 9 +++++---- 2 files changed, 10 insertions(+), 4 deletions(-) create mode 100644 changelog/unreleased/delay-reconnect-log.md diff --git a/changelog/unreleased/delay-reconnect-log.md b/changelog/unreleased/delay-reconnect-log.md new file mode 100644 index 0000000000..25bb58654b --- /dev/null +++ b/changelog/unreleased/delay-reconnect-log.md @@ -0,0 +1,5 @@ +Bugfix: delay reconnect log for events + +Print reconnect information log only when reconnect time is bigger than a second + +https://github.com/cs3org/reva/pull/2636 diff --git a/pkg/events/server/nats.go b/pkg/events/server/nats.go index a205b75cce..f59cf6bd28 100644 --- a/pkg/events/server/nats.go +++ b/pkg/events/server/nats.go @@ -19,10 +19,11 @@ package server import ( - "fmt" + "time" "github.com/asim/go-micro/plugins/events/nats/v4" "github.com/cenkalti/backoff" + "github.com/cs3org/reva/v2/pkg/logger" "go-micro.dev/v4/events" stanServer "github.com/nats-io/nats-streaming-server/server" @@ -46,10 +47,10 @@ func NewNatsStream(opts ...nats.Option) (events.Stream, error) { b := backoff.NewExponentialBackOff() var stream events.Stream o := func() error { + n := b.NextBackOff() s, err := nats.NewStream(opts...) - if err != nil { - // TODO: should we get the standard logger here? if yes: How? - fmt.Printf("can't connect to nats (stan) server, retrying in %s\n", b.NextBackOff()) + if err != nil && n > time.Second { + logger.New().Error().Err(err).Msgf("can't connect to nats (stan) server, retrying in %s", n) } stream = s return err