Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: modify to proper return type #854

Merged
merged 1 commit into from
Sep 17, 2024
Merged

fix: modify to proper return type #854

merged 1 commit into from
Sep 17, 2024

Conversation

schaoukicoveo
Copy link
Contributor

Acceptance Criteria

  • My changes are publicly available, documented, and deployed in production. (i.e. on Swagger)
  • JSDoc annotates each property added in the exported interfaces
  • The proposed changes are covered by unit tests
  • Commits containing breaking changes a properly identified as such
  • README.md is adjusted to reflect the proposed changes (if relevant)
  • My merge commit message will be conventional (See Conventional Commit)

@schaoukicoveo schaoukicoveo requested review from a team as code owners September 16, 2024 16:11
@schaoukicoveo schaoukicoveo added this pull request to the merge queue Sep 17, 2024
Merged via the queue into master with commit b453d33 Sep 17, 2024
5 checks passed
@schaoukicoveo schaoukicoveo deleted the fix/ORG-659 branch September 17, 2024 13:24
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 55.6.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdostie gdostie gdostie approved these changes

@alexprudhomme alexprudhomme alexprudhomme approved these changes

@dmgauthier dmgauthier Awaiting requested review from dmgauthier dmgauthier is a code owner automatically assigned from coveo/frontend-foundation

@olamothe olamothe Awaiting requested review from olamothe olamothe is a code owner automatically assigned from coveo/dx

@louis-bompart louis-bompart Awaiting requested review from louis-bompart louis-bompart is a code owner automatically assigned from coveo/dx

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schaoukicoveo @gdostie @alexprudhomme