Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency between needsClientUpdate and mp.msgUpdateClient resulting in potential nil message issue #1405

Closed
LeTrongDat opened this issue Feb 21, 2024 · 0 comments · Fixed by #1407
Assignees

Comments

@LeTrongDat
Copy link

The issue lies within this function processMessages when needsClientUpdate and mp.msgUpdateClient are not synchronized with each other, specifically, there can be a scenario where needsClientUpdate is true and mp.msgUpdateClient is nil. The reason is that in the function assembleMsgUpdateClient, it uses the condition !trustedConsensusHeight.EQ(clientConsensusHeight) however, this condition is absent in shouldUpdateClientNow. This leads to the scenario in trackAndSendMessages where it will call mp.sendClientUpdate with a nil msg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants