Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Token transfer deserialization fails when no memo #119

Closed
Farhad-Shabani opened this issue Jul 28, 2023 · 0 comments · Fixed by #120
Closed

Token transfer deserialization fails when no memo #119

Farhad-Shabani opened this issue Jul 28, 2023 · 0 comments · Fixed by #120
Labels
bug Something isn't working

Comments

@Farhad-Shabani
Copy link
Member

Farhad-Shabani commented Jul 28, 2023 •
edited
Loading

Problem Statement

context: cosmos/ibc-rs#792

When deserializing below JSON string w/o a memo field to the raw Protobuf type FungibleTokenPacketData serde_json fails.

r#"{"denom":"uatom","amount":"10","sender":"something","receiver":"something"}"#
@Farhad-Shabani Farhad-Shabani mentioned this issue Jul 28, 2023
Merged
@Farhad-Shabani Farhad-Shabani added the bug Something isn't working label Jul 28, 2023
ljoss17 added a commit that referenced this issue Sep 4, 2023
@ljoss17
Merge tag 'v0.32.1' into luca_joss/solomachine-lightclient-v3-from-v0.32
085e120 
ibc-proto-rs v0.32.1
*July 31st, 2023*

This release includes default `serde` value for token transfer memos and fixes
the issue with deserialization of `MsgTransfer` and `FungibleTokenPacketData`
types when no memo is present.

- Fix token transfer deserialization for cases with no memo by deriving
  `Default` serde for the memo field in `MsgTransfer` and
  `FungibleTokenPacketData` types.
  ([#119](#119))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: derive default serde on the memo fields of token transfer types cosmos/ibc-proto-rs
1 participant
@Farhad-Shabani