Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove errors for encode{,_length_delimited}_vec #73

Merged
merged 2 commits into from
Apr 6, 2023
Merged

Remove errors for encode{,_length_delimited}_vec #73

merged 2 commits into from
Apr 6, 2023

Conversation

kevinji
Copy link
Contributor

@kevinji kevinji commented Mar 31, 2023

These functions now use the underlying prost::Message functions that don't return any errors. The previous code didn't produce any errors anyways as the correct-capacity Vec would always be created, but this makes the code more explicit.

Copy link
Contributor

@plafer plafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll wait before merging to see if anyone else has comments on this

@romac romac merged commit df64803 into cosmos:main Apr 6, 2023
@kevinji kevinji deleted the encode-vec-no-error branch April 6, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants