Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create transfer packet data type based on channel version #6376

Closed
colin-axner opened this issue May 23, 2024 · 0 comments · Fixed by #6410
Closed

create transfer packet data type based on channel version #6376

colin-axner opened this issue May 23, 2024 · 0 comments · Fixed by #6410
Assignees
@DimitrisJim
Labels
20-transfer type: feature New features, sub-features or integrations
Milestone
ICS20 v2 (multi d...

Comments

@colin-axner
Copy link
Contributor

colin-axner commented May 23, 2024 •
edited by crodriguezvega
Loading

packet data type should be generated based on channel version. Lets open as issue and address after merge?

Originally posted by @colin-axner in #6352 (comment)

With the addition of ics20-v2, transfer should lookup the channel version and generate the packet data type based on the channel version to maintain backwards compatibility. It can simply convert to a v1 packet data from v2 and use v2 otherwise
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DimitrisJim DimitrisJim

Labels
20-transfer type: feature New features, sub-features or integrations
Projects
ibc-go
Archived in project
Milestone
ICS20 v2 (multi denom) alpha
Development

Successfully merging a pull request may close this issue.

fix(transfer): look-up channel version before sending a packet cosmos/ibc-go
3 participants
@crodriguezvega @DimitrisJim @colin-axner