Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the dependency on cosmossdk.io/simapp #3545

Closed
3 tasks
damiannolan opened this issue May 3, 2023 · 2 comments · Fixed by #3554
Closed
3 tasks

Remove the dependency on cosmossdk.io/simapp #3545

damiannolan opened this issue May 3, 2023 · 2 comments · Fixed by #3554
Labels
dependencies Issues or PRs to update a dependency type: code hygiene Clean up code but without changing functionality or interfaces

Comments

@damiannolan
Copy link
Member

damiannolan commented May 3, 2023

Summary

Our go module currently depends on cosmossdk.io/simapp. This module is pre-release and encapsulates the SDK's simulation app. We have no need to depend on this directly.

go mod why -m cosmossdk.io/simapp

# cosmossdk.io/simapp
github.com/cosmos/ibc-go/v7/testing/simapp/simd/cmd
cosmossdk.io/simapp/simd/cmd

We use the module to simply bootstrap the testnet subcommand of the ibc-go simapp. The testnet cmd can be redefined internally similarly to how prod apps do it. Alternatively we can remove this entirely if we don't see a need for the testnet subcommand.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@damiannolan damiannolan added dependencies Issues or PRs to update a dependency type: code hygiene Clean up code but without changing functionality or interfaces labels May 3, 2023
@DimitrisJim
Copy link
Contributor

wdyt should be done here? Is this something we use/will use?

@damiannolan
Copy link
Member Author

I think we can remove it and add it back later if its deemed necessary. I can make a quick PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Issues or PRs to update a dependency type: code hygiene Clean up code but without changing functionality or interfaces
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants