Make port keeper's IsBound a public function

[colin-axner]

Summary

Port Keeper has a function isBound which checks if the provided portID is already binded to a module.

Problem Definition

ICA needs to check if a portID is already bound, otherwise the port keeper will panic. I realized the current implementation incorrectly checks if the port is bound and does result in a panic. This only occurs if another module claimed a portID within the namespace ICA is working in

The problem was ICA was checking against its scoped keeper, replicating the code in 05-port. But 05-port checks against the IBC scoped keeper. So any port bound that ICA did not claim would cause a panic.

Proposal

The isBound function should be public OR return errors in 05-port instead of panicking #41

cc @AdityaSripal

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged/assigned

[seantking]

I can pick this up. Should we just make IsBound public?

[colin-axner]

I can pick this up. Should we just make IsBound public?

I'm in favor of it being public and eventually 05-port returning errors instead of panics, but the public change seems like a good short term fix

[seantking]

Nice. I'll make a PR, thanks. 👍