feat: add channel query client to e2e test suite #1985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colin-axner
requested review from
AdityaSripal,
crodriguezvega,
seantking,
charleenfei,
damiannolan and
chatton
as code owners
colin-axner
commented
Aug 11, 2022
| @@ -0,0 +1,23 @@ | |||
| package testsuite | |||
There was a problem hiding this comment.
thought it might be nice to have a separate file for core queries we support
colin-axner
commented
Aug 11, 2022
| channeltypes "github.com/cosmos/ibc-go/v5/modules/core/04-channel/types" | ||
| ) | ||
|
|
||
| // QueryPacketCommitment queries the packet commitment on the given chain for the provided channel and sequence. |
There was a problem hiding this comment.
Maybe we should add a AssertPacketIsRelayed function?
There was a problem hiding this comment.
Sounds like a useful assertion to have, we can always add it as we need it though if you don't want to include it in this PR.
chatton
approved these changes
Aug 11, 2022
| channeltypes "github.com/cosmos/ibc-go/v5/modules/core/04-channel/types" | ||
| ) | ||
|
|
||
| // QueryPacketCommitment queries the packet commitment on the given chain for the provided channel and sequence. |
There was a problem hiding this comment.
Sounds like a useful assertion to have, we can always add it as we need it though if you don't want to include it in this PR.
| @@ -0,0 +1,23 @@ | |||
| package testsuite | |||
3 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #1983
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes