E2E: Fee middleware counterparty payee not set #1746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chatton
requested review from
colin-axner,
AdityaSripal,
crodriguezvega,
seantking,
charleenfei and
damiannolan
as code owners
crodriguezvega
approved these changes
Aug 7, 2022
| packetId := channeltypes.NewPacketId(channelA.PortID, channelA.ChannelID, 1) | ||
| packetFee := feetypes.NewPacketFee(testFee, chainAWallet.Bech32Address(chainA.Config().Bech32Prefix), nil) | ||
|
|
||
| t.Run("should succeed", func(t *testing.T) { |
There was a problem hiding this comment.
Maybe something extra in the description to make it more explicit? Like pay packet fee should succeed?
There was a problem hiding this comment.
based on the nesting, the resulting message will look like TestPayPacketFeeAsync_SingleSender_NoCounterPartyAddress/pay_packet_fee/should_succeed
Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
colin-axner
approved these changes
Aug 10, 2022
e2e/fee_middleware_test.go
Outdated
| s.Require().Empty(packets) | ||
| }) | ||
|
|
||
| packetId := channeltypes.NewPacketId(channelA.PortID, channelA.ChannelID, 1) |
There was a problem hiding this comment.
Suggested change
| packetId := channeltypes.NewPacketId(channelA.PortID, channelA.ChannelID, 1) | |
| packetId := channeltypes.NewPacketId(chainATx.Packet.GetSourcePort(), chainATx.Packet.GetSourceChannel(), chainATx.Packet.GetSequence()) |
I think at least modifying the sequence to use the returned chainATx.Packet.GetSequence makes sense, I have no preference on the other arguments, I just figure this code will be copied a lot so might make more sense to derive the values
There was a problem hiding this comment.
ah definitely, good catch.
| var err error | ||
| payPacketFeeTxResp, err = s.PayPacketFeeAsync(ctx, chainA, chainAWallet, packetId, packetFee) | ||
| s.Require().NoError(err) | ||
| s.AssertValidTxResponse(payPacketFeeTxResp) |
There was a problem hiding this comment.
love this helper function ❤️
chatton
deleted the
cian/issue#1686-fee-middleware-counterparty-payee-not-set
branch
3 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #1686
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes