Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is the IBC module name, ibchost.ModuleName #1667

Closed
3 tasks
ValarDragon opened this issue Jul 6, 2022 · 2 comments · Fixed by #2982
Closed
3 tasks

Why is the IBC module name, ibchost.ModuleName #1667

ValarDragon opened this issue Jul 6, 2022 · 2 comments · Fixed by #2982
Assignees
Labels
client-UX type: refactor Architecture, code or CI improvements that may or may not tackle technical debt.
Milestone

Comments

@ValarDragon
Copy link
Contributor

ValarDragon commented Jul 6, 2022

Summary of Bug

Something I find confusing in dealing with the app wiring, is that the core IBC module's moduleName (https://github.com/cosmos/ibc-go/blob/main/modules/core/module.go#L43-L46) is ibchost.ModuleName. (In osmosis / most apps atm we alias that host import to be ibchost)

I erroneously thought this related to interchain accounts host, whereas really the begin block here is for updating IBC clients.

Could the location / name of this module name be moved around? (Perhaps even keeping it in the same folder?)


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner
Copy link
Contributor

We could move it to our exported directory. I agree it's an odd place to put the module name. It isn't in the types because the types because our types depend on submodules and our submodules depend on the ModuleName

Would it seem more logical if you used ibcexported.ModuleName?

@ValarDragon
Copy link
Contributor Author

yeah ibcexported.ModuleName would be nicer!

@colin-axner colin-axner added type: refactor Architecture, code or CI improvements that may or may not tackle technical debt. client-UX labels Nov 16, 2022
@chatton chatton self-assigned this Jan 6, 2023
@crodriguezvega crodriguezvega added this to the v7.0.0 milestone Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client-UX type: refactor Architecture, code or CI improvements that may or may not tackle technical debt.
Projects
Status: Done 🥳
Development

Successfully merging a pull request may close this issue.

4 participants