Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make EscrowPacketFee private #1059

Closed
3 tasks
colin-axner opened this issue Mar 3, 2022 · 1 comment · Fixed by #1252
Closed
3 tasks

Make EscrowPacketFee private #1059

colin-axner opened this issue Mar 3, 2022 · 1 comment · Fixed by #1252
Assignees
Labels

Comments

@colin-axner
Copy link
Contributor

Summary

We should move the IsFeeEnabled check to the message server and make EscrowPacketFee private. This makes the message MsgPayPacketFee and MsgPayPacketFeeAsync the only entry points to this function.

I noticed this might be a better approach while adding an IsLocked() check. I think it makes sense to remove security checks from EscrowPacketFee and have that function simply escrow the packet fee.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@crodriguezvega crodriguezvega added this to the Fee Middleware milestone Mar 4, 2022
@seantking seantking added the needs discussion Issues that need discussion before they can be worked on label Apr 6, 2022
@damiannolan
Copy link
Member

Seems like EscrowPacketFee is used extensively throughout the tests. We may be able to work around it by setting fees in store manually, as that appears to be the general purpose in most test cases.

@damiannolan damiannolan self-assigned this Apr 12, 2022
@damiannolan damiannolan removed the needs discussion Issues that need discussion before they can be worked on label Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants