Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KMS Signing support for relayer txs #577

Closed
ebuchman opened this issue Jan 26, 2021 · 9 comments
Closed

KMS Signing support for relayer txs #577

ebuchman opened this issue Jan 26, 2021 · 9 comments

Comments

@ebuchman
Copy link
Member

ebuchman commented Jan 26, 2021

As discussed in this Stargate issue and elsewhere, IBC messages in Stargate cannot be signed yet by Ledgers.

We should add hardware support for IBC message signing through the TMKMS. @zmanian @tony-iqlusion are there issues for this?

@tony-iqlusion
Copy link
Member

It should certainly be doable via a YubiHSM2.

How are you foreseeing an IBC relayer interacting with TMKMS? Would you like for TMKMS to expose a gRPC service?

@zmanian
Copy link
Member

zmanian commented Jan 26, 2021

My mental model is similar to the oracle architecture maybe.

@ebuchman
Copy link
Member Author

Yeh I think a gRPC makes sense, is that what the oracle uses ?

I guess there would also be the option for the rust relayer of running in process but that seems special case.

Any thoughts here @ancazamfir

@tony-iqlusion
Copy link
Member

@ebuchman the current transaction signer uses a JSON/HTTP webhook (which makes outgoing requests).

At the time we implemented it we needed Amino support, so it was easier to get started with Amino JSON.

However, now we have tendermint-proto, cosmos-sdk-proto, and cosmos-tx, so we can start working on defining a gRPC service.

@nooomski
Copy link
Contributor

Is this still relevant or can we close this? @ebuchman Not too familiar with IBC status on this. Thanks

@romac
Copy link
Member

romac commented Feb 15, 2022

There's no support for TMKMS in Hermes at the moment, so we can maybe keep this issue open to discuss relayer integration with TMKMS?

@tony-iqlusion
Copy link
Member

Would be good to discuss this after we have initial gRPC support

@ebuchman
Copy link
Member Author

I think the original issue may still stand but it prob doesn't need to be in this repo. @charleenfei @jackzampolin do you know if relayer txs can be signed by hardware yet ? should we move this issue somewhere to track it? I believe all relayers are currently just using text file private keys and that might be fine for now but as relayer balances increase this may become higher priority - cc @adizere @greg-szabo

@mmulji-ic
Copy link
Contributor

AFAIK This issue is no longer relevant, we'll close, please reopen if incorrect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants