Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Created sdk.Codec and deprecate clientContext.JSONCodec #9490

Closed
cyberbono3 opened this issue Jun 10, 2021 · 2 comments · Fixed by #9498
Closed

Created sdk.Codec and deprecate clientContext.JSONCodec #9490

cyberbono3 opened this issue Jun 10, 2021 · 2 comments · Fixed by #9498
Assignees
@robert-zaremba
Milestone
v0.43

Comments

@cyberbono3
Copy link
Contributor

cyberbono3 commented Jun 10, 2021 •
edited
Loading

Following @robert-zaremba comment, the major motivation for JSONCodec in SDK.Context was that we are using only JSON in user - node communication.
@cyberbono3 cyberbono3 self-assigned this Jun 10, 2021
@amaury1093
Copy link
Contributor

And also add with clientContext.Codec. We shouldn't deprecate something like this if there's no replacement.

@amaury1093 amaury1093 added this to the v0.43 milestone Jun 10, 2021
@robert-zaremba robert-zaremba changed the title Deprecate clientContext.JSONCodec Created sdk.Codec and deprecate clientContext.JSONCodec Jun 10, 2021
@robert-zaremba robert-zaremba mentioned this issue Jun 10, 2021
Merged
19 tasks
@robert-zaremba
Copy link
Collaborator

We also forgot to rename encCfg.Marshaler - it should be renamed to encCfg.Codec.

@robert-zaremba robert-zaremba mentioned this issue Jun 10, 2021
Closed
4 tasks
@mergify mergify bot closed this as completed in #9498 Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robert-zaremba robert-zaremba

Labels
None yet
Projects
None yet
Milestone
v0.43
Development

Successfully merging a pull request may close this issue.

refactor(client): add client/Context.Codec and deprecate JSONCodec cosmos/cosmos-sdk
4 participants
@aaronc @robert-zaremba @amaury1093 @cyberbono3