Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing go package option to proofs.proto #7562

Closed
blushi opened this issue Oct 15, 2020 · 1 comment · Fixed by #7565
Closed

Missing go package option to proofs.proto #7562

blushi opened this issue Oct 15, 2020 · 1 comment · Fixed by #7565

Comments

@blushi
Copy link
Contributor

blushi commented Oct 15, 2020 •
edited
Loading

option go_package = "github.com/confio/ics23/go"; is now missing from third_party/proto/confio/proofs.proto, which causes issues with proto files generation, in particular for proto/ibc/lightclients/tendermint/v1/tendermint.proto which imports confio/proofs.proto (see cosmos/ics23#32 for reference).

It has been removed as part of #7527 unintentionally I presume. This

cosmos-sdk/Makefile

Line 439 in 2323f1a

@sed -i '4ioption go_package = "github.com/confio/ics23/go";' $(CONFIO_TYPES)/proofs.proto
doesn't seem to work on Mac OS X.

cc / @marbar3778
@blushi blushi mentioned this issue Oct 15, 2020
Merged
9 tasks
@tac0turtle
Copy link
Member

Oh sorry. It did not work on mac, I had to comment it out when running the cmd.

@blushi blushi mentioned this issue Oct 15, 2020
Merged
9 tasks
@mergify mergify bot closed this as completed in #7565 Oct 15, 2020
@blushi blushi mentioned this issue Oct 15, 2020
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add back missing go package option to proofs.proto cosmos/cosmos-sdk
2 participants
@blushi @tac0turtle