Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish migration to grpc in IBC #6961

Closed
4 tasks
colin-axner opened this issue Aug 6, 2020 · 5 comments · Fixed by #7077
Closed
4 tasks

Finish migration to grpc in IBC #6961

colin-axner opened this issue Aug 6, 2020 · 5 comments · Fixed by #7077
Assignees

Comments

@colin-axner
Copy link
Contributor

Summary

Now that client state and consensus states have been migrated to proto, the querier in IBC should be removed and the client/consensus state grpc functions should be added.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@cwgoes
Copy link
Contributor

cwgoes commented Aug 12, 2020

Also, sounds like we need to figure out how proofs will work with gRPC queries/queriers.

@colin-axner
Copy link
Contributor Author

So for the short term I'm going to add a ABCI query helper func similar to the one in the testing package to ensure the +1 only happens once. I'll probably do a pr which renames client/utils to client/query with query.go. This file will contain functions that basically act as a wrapper around gRPC calls and use the helper func to inject a proof/proof height into the queries.

I think it is quite redundant to do a gRPC query and an ABCI query in the same call, so I will also open issue around my thoughts on how to handle adding proofs from within gRPC calls and at least get the conversation started around this issue. Though it isn't strictly necessary for 1.0 so I think its implementation is not high priority unless it seems to be relatively easy

cc/ @fedekunze @AdityaSripal

@colin-axner
Copy link
Contributor Author

opened #7036

@fedekunze
Copy link
Collaborator

Unrelated to the comment above, but I think we should drop the support for the legacy REST server and just use gRPC + gateway for REST-like queries.

@fedekunze fedekunze self-assigned this Aug 17, 2020
@colin-axner
Copy link
Contributor Author

Unrelated to the comment above, but I think we should drop the support for the legacy REST server and just use gRPC + gateway for REST-like queries.

I agree 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants