R4R: lazy commission validation #4466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colin-axner
requested review from
alessio,
alexanderbez,
jackzampolin and
rigelrozanski
as code owners
fedekunze
reviewed
Jun 2, 2019
fedekunze
added
the
T: API Breaking
|
Is this R4R @colin-axner ? |
colin-axner
changed the title
|
@alexanderbez yes |
alexanderbez
reviewed
Jun 3, 2019
alexanderbez
suggested changes
Jun 3, 2019
There was a problem hiding this comment.
LGTM, thanks @colin-axner. I have one minor nitpick on the change which makes this breaking.
Codecov Report
@@ Coverage Diff @@
## master #4466 +/- ##
=========================================
Coverage ? 54.59%
=========================================
Files ? 250
Lines ? 16074
Branches ? 0
=========================================
Hits ? 8775
Misses ? 6651
Partials ? 648 |
fedekunze
approved these changes
Jun 3, 2019
alexanderbez
reviewed
Jun 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3854
Changes
CommissionMsgtoCommissionRateswhich is embedded intoCommission. Adds rate validation intoMsgCreateValidator.ValidateBasic()Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added a relevant changelog entry:
clog add [section] [stanza] [message]rereviewed
Files changedin the github PR explorerFor Admin Use: