R4R: module inter-dependency cleanup

[rigelrozanski]

This is preperation PR for #2935 which effectively moves invariance checks from simulation testing to core functionality. As a part of this I wanted to remove inter-module dependencies (sometimes we've been more lax when it comes to testing). During this process I also noticed that outside of testing there were intermodule dependencies, so I took the liberty of clearing these up - as a part of this introducing some new expected keepers within modules which lacked that design.

Notes on where I attempted to remove inter-dependency:

• ignoring use within _test files
• ignoring use of params within other modules (requires params interface - which we should probably create)
• ignoring use of auth within other modules (require auth interfaces - which we should probably create)
• ignoring use of mock within simulation directories besides invariance (in prep for Broken-Invariant-Evidence Tx #2935)

There is still more cleanup due (see above points!) - but this PR is a good first step in de-spagetting the modules

REF: #3556

• Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
• [na] Wrote tests
• Updated relevant documentation (docs/)
• Added entries in PENDING.md with issue #
• rereviewed Files changed in the github PR explorer

---

For Admin Use:

• Added appropriate labels to PR (ex. wip, ready-for-review, docs)
• Reviewers Assigned
• Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

[codecov]

Codecov Report

Merging #3621 into develop will decrease coverage by 0.08%.
The diff coverage is 53.08%.

@@             Coverage Diff             @@
##           develop    #3621      +/-   ##
===========================================
- Coverage    60.99%   60.91%   -0.09%     
===========================================
  Files          187      188       +1     
  Lines        14069    14084      +15     
===========================================
- Hits          8582     8579       -3     
- Misses        4943     4961      +18     
  Partials       544      544

[cwgoes]

These changes seem reasonable to me, but I wonder if we should start using subpackages in types/ for generic types or functions associated with modules - e.g. for the staking code for default denomination & power conversions - the types/ package is pretty wide-ranging at the moment.

[rigelrozanski]

@cwgoes I'd gladly refactor the types package to include subpackages as a part of this PR

---

Edit: maybe actually we should wait to perform as a part of this major restructure: #1123 (which should be done in a separate PR - but probably done soon)

[jackzampolin]

@rigelrozanski maybe in a followup PR? This is getting pretty big already.

[jackzampolin]

Why do we have SDK in this function name?

[rigelrozanski]

Any suggestions for alternative names? I agree this is less than ideal - however I've marked this function for removal (while addressing #3386) so I'm not too too concerned about getting it perfect. Basically, this function is the same as GetAllDelegations except returning in sdk.Delegation instead os staking.Delegations

[alexanderbez]

LGTM except for the GetSDK* function names, not sure what it should be called, but I don't think we should have SDK in the method/function sigs.

[jackzampolin]

LGTM 👍

[jackzampolin]

Looks like there is a conflict here @rigelrozanski. Also read through this in detail and it didn't appear to have anything breaking. Can you confirm thats the case?

[rigelrozanski]

@jackzampolin the only thing which is api breaking is the rename from Bonds to Delegations for genesis staking staking.GenesisState.Bonds -> Delegations

There are no state-machine breaking changes

[jackzampolin]

Awesome! Thank you for the rebase @rigelrozanski