R4R: staking spec upgrades / some renaming

[rigelrozanski]

closes #3324

There are still slashing sections to be filled in for slashing in state-transitions.md but the motivation for me to complete this as a part of this PR doesn't exist, I suggest we merge what is here for now.

• Targeted PR against correct branch (see CONTRIBUTING.md)

• Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

• Wrote tests

• Updated relevant documentation (docs/)

• Added entries in PENDING.md with issue #

• rereviewed Files changed in the github PR explorer

---

For Admin Use:

• Added appropriate labels to PR (ex. wip, ready-for-review, docs)
• Reviewers Assigned
• Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

[codecov]

Codecov Report

Merging #3357 into develop will increase coverage by 0.1%.
The diff coverage is 58.92%.

@@            Coverage Diff             @@
##           develop    #3357     +/-   ##
==========================================
+ Coverage    55.51%   55.61%   +0.1%     
==========================================
  Files          141      141             
  Lines        10445    10437      -8     
==========================================
+ Hits          5799     5805      +6     
+ Misses        4306     4293     -13     
+ Partials       340      339      -1

[cwgoes]

This looks like a fair amount of staking code changes too - just general cleanup?

[rigelrozanski]

@cwgoes yes cleanup - also some name changes per the issue

[codecov]

Codecov Report

Merging #3357 into develop will increase coverage by 0.09%.
The diff coverage is 60%.

@@             Coverage Diff             @@
##           develop    #3357      +/-   ##
===========================================
+ Coverage    61.25%   61.35%   +0.09%     
===========================================
  Files          185      185              
  Lines        13982    13978       -4     
===========================================
+ Hits          8565     8576      +11     
+ Misses        4874     4860      -14     
+ Partials       543      542       -1

[cwgoes]

Mostly LGTM; a few nits and let's wait for #3507 first.

[rigelrozanski]

will wait for #3507 merge before fixes

[jackzampolin]

This needs a rebase cause #3507