Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swagger file on website should make request to full node #2948

Closed
4 tasks
fedekunze opened this issue Nov 29, 2018 · 6 comments
Closed
4 tasks

Swagger file on website should make request to full node #2948

fedekunze opened this issue Nov 29, 2018 · 6 comments
Assignees
Labels
T:Docs Changes and features related to documentation.

Comments

@fedekunze
Copy link
Collaborator

Summary of Bug

The requests are made to a wrong URL (https://cosmos.network/...)

Steps to Reproduce

  • go to the cosmos Swagger file here and pick a GET request (eg stake/validators which doesn't require any params),
  • Click Try it out > Execute

The request is made to the following URL https://cosmos.network/stake/validators while it should instead use our company full node http://fabo.interblock.io (or another)

cc: @cosmos/sre @jackzampolin @zramsay


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@fedekunze fedekunze added the T:Docs Changes and features related to documentation. label Nov 29, 2018
@fedekunze fedekunze changed the title Swagger file on website should make request to our full node Swagger file on website should make request to full node Nov 29, 2018
@alexanderbez
Copy link
Contributor

alexanderbez commented Nov 29, 2018

Yes -- thank you! I believe we discussed this a while back. Thanks for creating an issue. It should probably point to a LB'd node that we use for our testnets...unless we want to have a dedicated node for this.

@greg-szabo
Copy link
Member

greg-szabo commented Nov 29, 2018

Absolutely not. The Fabo node is a internal developer node for the UI team, it was and should not ever be published to the community.

@greg-szabo
Copy link
Member

greg-szabo commented Nov 29, 2018

If we want to publish full nodes to the community that needs to be discussed in more details. The only published node over HTTPS (which is required for cross-site requests) is the seed nodes aggregator point gaia-seeds.interblock.io

That point is down now due to no avaiable network running

@zramsay
Copy link
Contributor

zramsay commented Nov 29, 2018

i'm confused, the RPC endpoint (https://cosmos.network/rpc/) serves static files, why should it make resquests?

@fedekunze
Copy link
Collaborator Author

i'm confused, the RPC endpoint (https://cosmos.network/rpc/) serves static files, why should it make resquests?

@zramsay because swagger has that feature and i feel we should make use of it once we have a stable testnet/mainnet

@jackzampolin
Copy link
Member

@fedekunze This is a GREAT idea and we should totally have this working. I think pointing it at the voyager node in the interim is a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T:Docs Changes and features related to documentation.
Projects
None yet
Development

No branches or pull requests

5 participants