Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Automatically set --from flag if one key in keyring #17971

Closed
julienrbrt opened this issue Oct 5, 2023 · 2 comments · Fixed by #18101
Closed

[Feature]: Automatically set --from flag if one key in keyring #17971

julienrbrt opened this issue Oct 5, 2023 · 2 comments · Fixed by #18101

Comments

@julienrbrt
Copy link
Member

julienrbrt commented Oct 5, 2023

Summary

The --from flag is mandatory for each tx command unless set as a positional argument.
AutoCLI has access to the keyring and uses it for resolving key names in commands.

We can improve the UX of AutoCLI commands, and automatically set the --from flag if there is only one key in the keyring.
This would avoid to always need to specify the --from flag.

ref: #17913 (comment)

Problem Definition

No response

Proposed Feature

Automatically set --from flag if one key in keyring in AutoCLI.

We should check if this works well and is not annoying with a keyring with a password.

@anilcse
Copy link
Collaborator

anilcse commented Oct 10, 2023

Sounds good. How about also allowing users to configure default if they have multiple?

@julienrbrt
Copy link
Member Author

Sounds good. How about also allowing users to configure default if they have multiple?

I like this idea better tbh 👍🏾, this way it works with AutoCLI and for normal commands directly and avoids the keyring lookup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants