Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit simapp v0.47..v0.50 #16864

Closed
julienrbrt opened this issue Jul 6, 2023 · 3 comments
Closed

Audit simapp v0.47..v0.50 #16864

julienrbrt opened this issue Jul 6, 2023 · 3 comments
Assignees
@alexanderbez @julienrbrt
Labels
T: Audit

Comments

@julienrbrt
Copy link
Member

No description provided.

@julienrbrt julienrbrt mentioned this issue Jul 6, 2023
Closed
52 tasks
@julienrbrt julienrbrt changed the title Audit simapp v0.47..v0.50 (@julienrbrt + TBD) Audit simapp v0.47..v0.50 Jul 6, 2023
@github-actions github-actions bot added the needs-triage Issue that needs to be triaged label Jul 6, 2023
@julienrbrt julienrbrt added R:Eden T: Audit and removed needs-triage Issue that needs to be triaged labels Jul 6, 2023
@julienrbrt julienrbrt mentioned this issue Jul 6, 2023
Merged
19 tasks
@julienrbrt
Copy link
Member Author

julienrbrt commented Jul 10, 2023 •
edited
Loading

What do we do about this: https://github.com/cosmos/cosmos-sdk/tree/main/simapp/internal/testnet ?
I believe this is not yet ready. I think we should delete it from release/v0.50.x branch (but stay on main) and we can improve it when someone picks up the work on that again. Wdyt?

@alexanderbez
Copy link
Contributor

@julienrbrt yes, I think that's a fine idea 👍

@julienrbrt julienrbrt mentioned this issue Jul 10, 2023
Merged
19 tasks
@alexanderbez
Copy link
Contributor

I didn't find any major discrepancies or issues. The minor items @julienrbrt found are the bulk of what should be fixed. Thanks @julienrbrt!

@julienrbrt julienrbrt mentioned this issue Jul 19, 2023
Merged
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexanderbez alexanderbez

@julienrbrt julienrbrt

Labels
T: Audit
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexanderbez @julienrbrt