Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit x/gov v0.47...v0.50 #16781

Closed
likhita-809 opened this issue Jun 30, 2023 · 1 comment · Fixed by #16870
Closed

Audit x/gov v0.47...v0.50 #16781

likhita-809 opened this issue Jun 30, 2023 · 1 comment · Fixed by #16870
Assignees
@likhita-809
Labels
C:x/gov T: Audit

Comments

@likhita-809
Copy link
Contributor

No description provided.

@likhita-809 likhita-809 mentioned this issue Jun 30, 2023
Closed
52 tasks
@github-actions github-actions bot added the needs-triage Issue that needs to be triaged label Jun 30, 2023
@likhita-809 likhita-809 added C:x/gov T:Sprint T: Audit and removed needs-triage Issue that needs to be triaged labels Jun 30, 2023
@likhita-809 likhita-809 self-assigned this Jun 30, 2023
This was referenced Jul 4, 2023
Closed
Merged
@likhita-809
Copy link
Contributor Author

Changes found and tested when necessary:

  • we have constitution field in genesis state which defines purpose of chain
  • Expedited option is provided in gov v1 proposal and it works fine.
  • previously proposal status used to log only when proposal exec passes, now it logs even when proposal passes but fails to execute.
  • we are using MsgRouter interface in NewKeeper
  • we are checking that proposal metadata's title and summary matches the proposal's title and summary
  • migration to KVStoreService
  • gRPC query methods are now handled by queryServer instead of Keeper
  • Usage of collections and removal of several methods
  • submit-legacy-proposal and cancel-software-upgrade cmds no longer live in gov module
  • small json format fix for gov vote tx response

Changes needed:

  • few nits
  • removal of GetSigners
  • improve codecov & add missing tests

@atheeshp atheeshp mentioned this issue Jul 7, 2023
Merged
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@likhita-809 likhita-809

Labels
C:x/gov T: Audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: gov audit (secondary reviewer) cosmos/cosmos-sdk
1 participant
@likhita-809