Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit x/auth v0.47...v0.50 #16693

Closed
kocubinski opened this issue Jun 26, 2023 · 2 comments
Closed

Audit x/auth v0.47...v0.50 #16693

kocubinski opened this issue Jun 26, 2023 · 2 comments
Assignees
@kocubinski
Labels
T: Audit

Comments

@kocubinski
Copy link
Member

No description provided.

@kocubinski kocubinski mentioned this issue Jun 26, 2023
Closed
52 tasks
@kocubinski kocubinski self-assigned this Jun 26, 2023
@github-actions github-actions bot added the needs-triage Issue that needs to be triaged label Jun 26, 2023
@kocubinski kocubinski changed the title Audit x/auth v0.47...v0.50 (@kocubinski + TBD) Audit x/auth v0.47...v0.50 Jun 26, 2023
@tac0turtle tac0turtle added T:Sprint T: Audit and removed needs-triage Issue that needs to be triaged labels Jun 26, 2023
@kocubinski
Copy link
Member Author

kocubinski commented Jul 11, 2023 •
edited
Loading

Major changes include migration to x/tx for signing from x/auth/tx and introduction of collections for the account keeper. Overall I don't love all the mapping code required for the x/tx but don't see an alternative which doesn't include a rewrite at the moment. It also highlights the confusing caused by supporting both legacy gogo proto and the current proto buf (protoreflect API) code. I wonder if this confusion and tension can be resolved in the SDK.

@kocubinski kocubinski mentioned this issue Jul 11, 2023
Merged
19 tasks
@atheeshp atheeshp mentioned this issue Jul 13, 2023
Closed
19 tasks
@atheeshp
Copy link
Contributor

overall lgtm,

Changes observed:

  • sdk.Context to context.Context
  • tx signing
  • msgs ValidateBasic migrated
  • collection migration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kocubinski kocubinski

Labels
T: Audit
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kocubinski @tac0turtle @atheeshp