Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit x/circuit v0.47...v0.50 #16506

Closed
samricotta opened this issue Jun 12, 2023 · 3 comments
Closed

Audit x/circuit v0.47...v0.50 #16506

samricotta opened this issue Jun 12, 2023 · 3 comments
Assignees
@samricotta
Labels
C:x/circuit T: Audit

Comments

@samricotta
Copy link
Contributor

No description provided.

@samricotta samricotta mentioned this issue Jun 12, 2023
Closed
52 tasks
@github-actions github-actions bot added the needs-triage Issue that needs to be triaged label Jun 12, 2023
@samricotta samricotta self-assigned this Jun 12, 2023
@tac0turtle tac0turtle added T:Sprint C:x/circuit and removed needs-triage Issue that needs to be triaged labels Jun 12, 2023
This was referenced Jul 10, 2023
Closed
Merged
@likhita-809
Copy link
Contributor

Changes found:

  • circuit breaker module implementation is added
  • usage of collections and KVStoreService.
  • own go mod

Improvements that could be done:

  • enhancing missing test coverage
  • remove GetSigners
  • inconsistent naming in few files to be fixed
  • Minor changes to README for better clarification
  • adding missing genesis tests and testcases in other tests
  • few nits

@tac0turtle
Copy link
Member

want to make some of those changes @likhita-809

@likhita-809
Copy link
Contributor

want to make some of those changes @likhita-809

Already done as part of #16901

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samricotta samricotta

Labels
C:x/circuit T: Audit
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tac0turtle @samricotta @likhita-809