Return errors in keeper methods instead of panicking

[facundomedica]

Summary

Now that we are using the new storeService that returns an error for all methods we can return them instead of panic. It might need some other changes like stop using Must... kind of functions

Problem Definition

We panic in many different places.

Proposal

Stop panicking and be responsible for your errors

Module list

Beta Give feedback

1. Auth
2. Authz
3. Bank
4. Circuit
5. Consensus
6. Feegrant
7. Evidence
8. Gov
9. Group
10. Staking
11. Distribution
12. Upgrade
13. Slashing
14. mint

[tac0turtle]

for begin and endblock we should have a way for users to say which error should halt the chain and which shouldnt. lots of benign issues could be avoided

[facundomedica]

Maybe like a type "CriticalError", so if you get this type panic, and if not just log it

[tac0turtle]

yea that could work. this is the epic that eludes to something as well. #12985.

[alexanderbez]

Yes, totally in favor of errors where possible. I imagine 90% of keeper/module code can error. The only thing that needs to be able to panic is Begin/EndBlock and Message handlers.

[chandiniv1]

@facundomedica @tac0turtle can I take this issue?

[likhita-809]

@tac0turtle closing this issue. As it is already addressed by #18636