Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutoCLI app command generation #13283

Closed
Tracked by #11775
aaronc opened this issue Sep 14, 2022 · 1 comment · Fixed by #13867
Closed
Tracked by #11775

AutoCLI app command generation #13283

aaronc opened this issue Sep 14, 2022 · 1 comment · Fixed by #13867
Labels

Comments

@aaronc
Copy link
Member

aaronc commented Sep 14, 2022

Add an auto-cli method to generate a full client from an app based on the module options and custom commands from #13282.

For now, this full client will necessarily be less complete than the current CLI. Over time we will fill in the missing pieces.

@aaronc aaronc mentioned this issue Sep 14, 2022
33 tasks
@aaronc aaronc changed the title AutoCLI app command AutoCLI app command generation Sep 14, 2022
@aaronc
Copy link
Member Author

aaronc commented Nov 28, 2022

One thing I'm trying to figure out when combining autocli and existing *cobra.Command's is how to specify the gRPC endpoint.

The current --node flag only points to the tendermint RPC endpoint and when gRPC is used, we just route it through tendermint ABCI query which is pretty inefficient. autocli on the other hand attempts to be gRPC native and could work without tendermint RPC.

I propose we add a flag --grpc or --grpc-endpoint which both the existing commands and autocli can use instead of --node if it's specific. And then autocli could fallback to ABCI query if only --node is specified.

How does that sound?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants