From 3ede42b462ae9c88759e8e44921b9ca99748d0db Mon Sep 17 00:00:00 2001
From: "mergify[bot]" <37929162+mergify[bot]@users.noreply.github.com>
Date: Fri, 30 Jun 2023 11:39:27 +0000
Subject: [PATCH] refactor(x/upgrade): audit changes (backport #16786) (#16797)

Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com>
---
 x/upgrade/keeper/msg_server.go |  8 +++++---
 x/upgrade/types/msgs.go        | 19 -------------------
 2 files changed, 5 insertions(+), 22 deletions(-)
 delete mode 100644 x/upgrade/types/msgs.go

diff --git a/x/upgrade/keeper/msg_server.go b/x/upgrade/keeper/msg_server.go
index 7c8cc8a48c35..e4f93473b7db 100644
--- a/x/upgrade/keeper/msg_server.go
+++ b/x/upgrade/keeper/msg_server.go
@@ -22,7 +22,10 @@ func NewMsgServerImpl(k *Keeper) types.MsgServer {
 	}
 }
 
-var _ types.MsgServer = msgServer{}
+var (
+	_    types.MsgServer = msgServer{}
+	_, _ sdk.Msg         = &types.MsgSoftwareUpgrade{}, &types.MsgCancelUpgrade{}
+)
 
 // SoftwareUpgrade implements the Msg/SoftwareUpgrade Msg service.
 func (k msgServer) SoftwareUpgrade(goCtx context.Context, msg *types.MsgSoftwareUpgrade) (*types.MsgSoftwareUpgradeResponse, error) {
@@ -49,8 +52,7 @@ func (k msgServer) CancelUpgrade(ctx context.Context, msg *types.MsgCancelUpgrad
 		return nil, errors.Wrapf(gov.ErrInvalidSigner, "expected %s got %s", k.authority, msg.Authority)
 	}
 
-	sdkCtx := sdk.UnwrapSDKContext(ctx)
-	err := k.ClearUpgradePlan(sdkCtx)
+	err := k.ClearUpgradePlan(ctx)
 	if err != nil {
 		return nil, err
 	}
diff --git a/x/upgrade/types/msgs.go b/x/upgrade/types/msgs.go
deleted file mode 100644
index 84ff4f6c926b..000000000000
--- a/x/upgrade/types/msgs.go
+++ /dev/null
@@ -1,19 +0,0 @@
-package types
-
-import (
-	sdk "github.com/cosmos/cosmos-sdk/types"
-)
-
-var _, _ sdk.Msg = &MsgSoftwareUpgrade{}, &MsgCancelUpgrade{}
-
-// GetSigners returns the expected signers for MsgSoftwareUpgrade.
-func (m *MsgSoftwareUpgrade) GetSigners() []sdk.AccAddress {
-	addr, _ := sdk.AccAddressFromBech32(m.Authority)
-	return []sdk.AccAddress{addr}
-}
-
-// GetSigners returns the expected signers for MsgCancelUpgrade.
-func (m *MsgCancelUpgrade) GetSigners() []sdk.AccAddress {
-	addr, _ := sdk.AccAddressFromBech32(m.Authority)
-	return []sdk.AccAddress{addr}
-}