From 9626f4862887f2a184c33348cc7cbd29aabf0fdf Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jo=C5=BEe=20Fortun?= Date: Wed, 1 Nov 2023 16:49:11 +0100 Subject: [PATCH] Add hints for configurations that impact performance --- .../Admin/Module/Records/ColumnPicker.vue | 10 +- .../components/Admin/Module/UniqueValues.vue | 6 ++ .../compose/src/components/Common/Hint.c3.js | 15 --- .../compose/src/components/Common/Hint.vue | 22 ----- .../ModuleFields/Configurator/Record.vue | 13 ++- .../ModuleFields/Configurator/validation.vue | 97 ++++++++++--------- .../components/ModuleFields/Editor/Bool.vue | 8 +- .../ModuleFields/Editor/DateTime.vue | 4 +- .../components/ModuleFields/Editor/Email.vue | 4 +- .../components/ModuleFields/Editor/File.vue | 4 +- .../ModuleFields/Editor/Geometry.vue | 4 +- .../components/ModuleFields/Editor/Number.vue | 4 +- .../components/ModuleFields/Editor/Record.vue | 4 +- .../components/ModuleFields/Editor/Select.vue | 4 +- .../components/ModuleFields/Editor/String.vue | 4 +- .../components/ModuleFields/Editor/Url.vue | 4 +- .../components/ModuleFields/Editor/User.vue | 4 +- .../components/ModuleFields/Editor/base.vue | 5 - .../src/components/PageBlocks/RecordBase.vue | 47 ++++----- .../PageBlocks/RecordConfigurator.vue | 5 + .../components/PageBlocks/RecordEditor.vue | 19 ++-- .../PageBlocks/RecordListConfigurator.vue | 67 ++++++++++--- client/web/compose/src/components/index.js | 1 + .../compose/src/views/Admin/Pages/Builder.vue | 4 +- .../compose/src/views/Admin/Pages/Edit.vue | 10 +- lib/vue/src/components/hint/CHint.vue | 39 ++++++++ lib/vue/src/components/hint/index.ts | 1 + lib/vue/src/components/index.ts | 4 + .../src/components/input/CInputConfirm.vue | 6 ++ locale/en/corteza-webapp-compose/block.yaml | 10 +- locale/en/corteza-webapp-compose/field.yaml | 7 +- locale/en/corteza-webapp-compose/module.yaml | 4 + .../corteza-webapp-compose/notification.yaml | 2 +- locale/en/corteza-webapp-compose/page.yaml | 2 + 34 files changed, 253 insertions(+), 191 deletions(-) delete mode 100644 client/web/compose/src/components/Common/Hint.c3.js delete mode 100644 client/web/compose/src/components/Common/Hint.vue create mode 100644 lib/vue/src/components/hint/CHint.vue create mode 100644 lib/vue/src/components/hint/index.ts diff --git a/client/web/compose/src/components/Admin/Module/Records/ColumnPicker.vue b/client/web/compose/src/components/Admin/Module/Records/ColumnPicker.vue index ce623ef883..a00ca8a369 100644 --- a/client/web/compose/src/components/Admin/Module/Records/ColumnPicker.vue +++ b/client/web/compose/src/components/Admin/Module/Records/ColumnPicker.vue @@ -11,12 +11,20 @@ id="columns" size="lg" scrollable - :title="$t('allRecords.columns.title')" :ok-title="$t('general.label.saveAndClose')" cancel-variant="link" body-class="p-0" + title-class="d-flex align-items-center p-0" @ok="onSave" > + + diff --git a/client/web/compose/src/components/Admin/Module/UniqueValues.vue b/client/web/compose/src/components/Admin/Module/UniqueValues.vue index 02b7e718a6..a6b67448cb 100644 --- a/client/web/compose/src/components/Admin/Module/UniqueValues.vue +++ b/client/web/compose/src/components/Admin/Module/UniqueValues.vue @@ -1,5 +1,11 @@ - - diff --git a/client/web/compose/src/components/ModuleFields/Configurator/Record.vue b/client/web/compose/src/components/ModuleFields/Configurator/Record.vue index 6ab260fb14..685edd3b08 100644 --- a/client/web/compose/src/components/ModuleFields/Configurator/Record.vue +++ b/client/web/compose/src/components/ModuleFields/Configurator/Record.vue @@ -15,10 +15,15 @@ diff --git a/client/web/compose/src/components/ModuleFields/Editor/Bool.vue b/client/web/compose/src/components/ModuleFields/Editor/Bool.vue index 363090660e..fb078af706 100644 --- a/client/web/compose/src/components/ModuleFields/Editor/Bool.vue +++ b/client/web/compose/src/components/ModuleFields/Editor/Bool.vue @@ -21,9 +21,7 @@ {{ label }} - + @@ -46,9 +44,7 @@ > {{ label }} - + diff --git a/client/web/compose/src/components/ModuleFields/Editor/DateTime.vue b/client/web/compose/src/components/ModuleFields/Editor/DateTime.vue index df995ddb66..051543b323 100644 --- a/client/web/compose/src/components/ModuleFields/Editor/DateTime.vue +++ b/client/web/compose/src/components/ModuleFields/Editor/DateTime.vue @@ -21,9 +21,7 @@ {{ label }} - + diff --git a/client/web/compose/src/components/ModuleFields/Editor/Email.vue b/client/web/compose/src/components/ModuleFields/Editor/Email.vue index f321613829..2a0184967c 100644 --- a/client/web/compose/src/components/ModuleFields/Editor/Email.vue +++ b/client/web/compose/src/components/ModuleFields/Editor/Email.vue @@ -21,9 +21,7 @@ {{ label }} - + diff --git a/client/web/compose/src/components/ModuleFields/Editor/File.vue b/client/web/compose/src/components/ModuleFields/Editor/File.vue index 521e38f554..bb2fbd8e49 100644 --- a/client/web/compose/src/components/ModuleFields/Editor/File.vue +++ b/client/web/compose/src/components/ModuleFields/Editor/File.vue @@ -20,9 +20,7 @@ {{ label }} - + diff --git a/client/web/compose/src/components/ModuleFields/Editor/Geometry.vue b/client/web/compose/src/components/ModuleFields/Editor/Geometry.vue index 85ce5390e0..87d662ccde 100644 --- a/client/web/compose/src/components/ModuleFields/Editor/Geometry.vue +++ b/client/web/compose/src/components/ModuleFields/Editor/Geometry.vue @@ -21,9 +21,7 @@ {{ label }} - + diff --git a/client/web/compose/src/components/ModuleFields/Editor/Number.vue b/client/web/compose/src/components/ModuleFields/Editor/Number.vue index 9d4bbb374c..478f11aba1 100644 --- a/client/web/compose/src/components/ModuleFields/Editor/Number.vue +++ b/client/web/compose/src/components/ModuleFields/Editor/Number.vue @@ -20,9 +20,7 @@ {{ label }} - + diff --git a/client/web/compose/src/components/ModuleFields/Editor/Record.vue b/client/web/compose/src/components/ModuleFields/Editor/Record.vue index 0b39d892d3..87bab70e12 100644 --- a/client/web/compose/src/components/ModuleFields/Editor/Record.vue +++ b/client/web/compose/src/components/ModuleFields/Editor/Record.vue @@ -20,9 +20,7 @@ {{ label }} - + diff --git a/client/web/compose/src/components/ModuleFields/Editor/Select.vue b/client/web/compose/src/components/ModuleFields/Editor/Select.vue index ad8a16a0c6..7b6d5b742a 100644 --- a/client/web/compose/src/components/ModuleFields/Editor/Select.vue +++ b/client/web/compose/src/components/ModuleFields/Editor/Select.vue @@ -20,9 +20,7 @@ {{ label }} - + diff --git a/client/web/compose/src/components/ModuleFields/Editor/String.vue b/client/web/compose/src/components/ModuleFields/Editor/String.vue index d850cf7a94..9b2c56c383 100644 --- a/client/web/compose/src/components/ModuleFields/Editor/String.vue +++ b/client/web/compose/src/components/ModuleFields/Editor/String.vue @@ -21,9 +21,7 @@ {{ label }} - + diff --git a/client/web/compose/src/components/ModuleFields/Editor/Url.vue b/client/web/compose/src/components/ModuleFields/Editor/Url.vue index d00143eaab..ff468f022d 100644 --- a/client/web/compose/src/components/ModuleFields/Editor/Url.vue +++ b/client/web/compose/src/components/ModuleFields/Editor/Url.vue @@ -20,9 +20,7 @@ {{ label }} - + diff --git a/client/web/compose/src/components/ModuleFields/Editor/User.vue b/client/web/compose/src/components/ModuleFields/Editor/User.vue index d0ed25d2f4..d53e7b1bdc 100644 --- a/client/web/compose/src/components/ModuleFields/Editor/User.vue +++ b/client/web/compose/src/components/ModuleFields/Editor/User.vue @@ -20,9 +20,7 @@ {{ label }} - + diff --git a/client/web/compose/src/components/ModuleFields/Editor/base.vue b/client/web/compose/src/components/ModuleFields/Editor/base.vue index 390e1c58d9..cf1222660b 100644 --- a/client/web/compose/src/components/ModuleFields/Editor/base.vue +++ b/client/web/compose/src/components/ModuleFields/Editor/base.vue @@ -14,7 +14,6 @@ import multi from './multi' import errors from '../errors' import { compose, validator } from '@cortezaproject/corteza-js' -import Hint from 'corteza-webapp-compose/src/components/Common/Hint.vue' export default { components: { @@ -25,10 +24,6 @@ export default { // errors is used in the components that extends base // eslint-disable-next-line vue/no-unused-components errors, - - // Hint is used in the components that extends base - // eslint-disable-next-line vue/no-unused-components - Hint, }, props: { diff --git a/client/web/compose/src/components/PageBlocks/RecordBase.vue b/client/web/compose/src/components/PageBlocks/RecordBase.vue index 5172eef16c..cb1597a055 100644 --- a/client/web/compose/src/components/PageBlocks/RecordBase.vue +++ b/client/web/compose/src/components/PageBlocks/RecordBase.vue @@ -22,37 +22,32 @@ :label-cols-xl="options.horizontalFieldLayoutEnabled && '4'" :content-cols-md="options.horizontalFieldLayoutEnabled && '7'" :content-cols-xl="options.horizontalFieldLayoutEnabled && '8'" + label-class="d-flex align-items-center text-primary mb-0" class="field-container mb-3 px-3" >