Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

High CPU usage when modifying custom CSS #1713

Closed
1 task done
moalamri opened this issue Feb 29, 2024 · 9 comments
Closed
1 task done

High CPU usage when modifying custom CSS #1713

moalamri opened this issue Feb 29, 2024 · 9 comments
Assignees
Labels
backend Backend server changes (GO) no-issue-activity
Milestone

Comments

@moalamri
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Version of Corteza

2023.9

Current Behavior

When editing the Custom CSS, most of the time it runs ok, but sometimes it takes alot of time before returning a timeout, I monitored the server resources and it shows as following
IMG_7318

Expected Behavior

No response

Steps To Reproduce

  1. Change Custom CSS
  2. Hit Submit

Environment and versions

No response

Anything else?

No response

@Fajfa
Copy link
Member

Fajfa commented Mar 1, 2024

Ok thanks, we'll take a look at that. Strange since it works without much processing on my end

@Fajfa Fajfa added the backend Backend server changes (GO) label Mar 1, 2024
@Fajfa Fajfa added this to the 2023.9.5 milestone Mar 1, 2024
@moalamri
Copy link
Contributor Author

moalamri commented Mar 1, 2024

Hi @Fajfa
Whenever this happens, I check the action log and it's filled with such records

image

Please let me know if I can do anything else to helps you debug this
Thank you

@Fajfa Fajfa modified the milestones: 2023.9.5, 2024.3.x Mar 20, 2024
@Fajfa Fajfa reopened this Mar 29, 2024
@Fajfa
Copy link
Member

Fajfa commented Mar 29, 2024

@moalamri
Copy link
Contributor Author

@Fajfa I’m sorry for closing the issue earlier because I thought it was from my setup. Glad to see that you have spotted the issue.

@Fajfa Fajfa modified the milestones: 2024.3.x, 2024.3.0 Apr 15, 2024
@KinyaElGrande
Copy link
Contributor

KinyaElGrande commented May 17, 2024

@moalamri

I believe the root of the issue lies within Dart-Sass, particularly regarding the specific versions of Dart-Sass you're using.
Could you please provide the dart-sass version and if possible the style sheets as well?

I've repeteadly updated my stylesheets on corteza's custom-css-editor to lines spanning more than 25k while monitoring my CPU, which showed a steady pattern of spikes and drops.

Furthermore, there have been documented reports of CPU performance issues associated with Dart-Sass, as indicated by various issues such as:

Nevertheless, the Dart-Sass team asserts that many of these performance issues have been addressed in versions beyond v1.61.0.

Corteza's custon-css-editor screenshot

Screenshot 2024-05-17 at 17 33 07

CPU metrics screenshot

Screenshot 2024-05-17 at 17 37 51

@moalamri
Copy link
Contributor Author

Hey @KinyaElGrande
I'm sorry for not being able to reproduce this again since I don't using Corteza for now and I remember it was a bit tricky to get it up and running because of proxy network is not being created or something, so I can't setup it again for further debugging.

I remember my Custom CSS was only few lines ~10 line or so. So, it wasn't a matter of payload size...
I wish I could be more helpful. I hope you can figure the issue and fix it if it does exist with other users.

Copy link

Stale issue message

@KinyaElGrande
Copy link
Contributor

I believe this issue is related to #1856, which has been resolved.

@moalamri
Copy link
Contributor Author

@KinyaElGrande You can close this issue and I will reopen it once I test the platform again and confirm if the issue still exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Backend server changes (GO) no-issue-activity
Projects
None yet
Development

No branches or pull requests

3 participants