Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change UI layout and logic for deduplication detection #1585

Closed
6 tasks done
petergrlica opened this issue Dec 8, 2023 · 0 comments · Fixed by #1586
Closed
6 tasks done

Change UI layout and logic for deduplication detection #1585

petergrlica opened this issue Dec 8, 2023 · 0 comments · Fixed by #1586
Assignees
@petergrlica @Fajfa
Labels
backend Backend server changes (GO) codebase improvements Various codebase improvements critical enhancement New feature or request frontend Frontend code changes (Javascript, Typescript, Vue.js) go Pull requests that update Go code
Milestone
2023.9.2

Comments

@petergrlica
Copy link
Member

petergrlica commented Dec 8, 2023 •
edited
Loading

Deduplication default settings are incorrectly added to backend, which eventually slows down the system.

Frontend:

  • add deduplication toggle button for each module on "unique values" tab
  • by default there should be no constraint added

Backend:

  • change default value to be recordDeDup: { enabled: false, rules: [] }
  • return config.recordDeDup.enabled in module response
  • if there is a constraint added it cannot be saved if there is no field defined for that constraint
  • ignore invalid settings already in the system (empty field info)
@petergrlica petergrlica added enhancement New feature or request backend Backend server changes (GO) frontend Frontend code changes (Javascript, Typescript, Vue.js) codebase improvements Various codebase improvements go Pull requests that update Go code critical labels Dec 8, 2023
@petergrlica petergrlica added this to the 2023.9.2 milestone Dec 8, 2023
@Fajfa Fajfa linked a pull request Dec 11, 2023 that will close this issue
Adjust module record dedup UX #1586
Merged
6 tasks
@Fajfa Fajfa closed this as completed Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petergrlica petergrlica

@Fajfa Fajfa

Labels
backend Backend server changes (GO) codebase improvements Various codebase improvements critical enhancement New feature or request frontend Frontend code changes (Javascript, Typescript, Vue.js) go Pull requests that update Go code
Projects
None yet
Milestone
2023.9.2
Development

Successfully merging a pull request may close this issue.

Adjust module record dedup UX cortezaproject/corteza
2 participants
@petergrlica @Fajfa