Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(camera): was not updating the viewUp and making the examples searchable in the prompt #865

Merged
merged 5 commits into from
Nov 3, 2023

Conversation

sedghi
Copy link
Member

@sedghi sedghi commented Nov 2, 2023

Context

CleanShot.2023-11-02.at.15.48.50.mp4

Changes & Results

Testing

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] "OS:
  • [] "Node version:
  • [] "Browser:

Copy link

netlify bot commented Nov 2, 2023

Deploy Preview for cornerstone-3d-docs ready!

Name Link
🔨 Latest commit ba73137
🔍 Latest deploy log https://app.netlify.com/sites/cornerstone-3d-docs/deploys/6543fd0a3878620007accc4a
😎 Deploy Preview https://deploy-preview-865--cornerstone-3d-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sedghi sedghi changed the title fix/viewup camera fix(camera): was not updating the viewUp and making the examples searchable in the prompt Nov 2, 2023
@sedghi sedghi requested a review from jbocce November 2, 2023 19:49
Copy link
Contributor

@jbocce jbocce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Approved!

Copy link
Contributor

@jbocce jbocce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Approved!

@sedghi sedghi merged commit 72a3ed6 into main Nov 3, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants