fix(getDataInTime): to consider different image spacing for reference #835
Conversation
✅ Deploy Preview for cornerstone-3d-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| const frame = frames[i]; | ||
| perFrameSum.set(frame, perFrameSum.get(frame) + value); | ||
| } | ||
| count++; |
There was a problem hiding this comment.
Should leave a comment here. count is representing the number of voxels of the dynamicVolume that represents one voxel in the mask, but the fact that a callback function modifying a global variable is dangerous
| values.push(averageValues); | ||
| }; | ||
|
|
||
| pointInShapeCallback(maskImageData, () => true, callback); |
There was a problem hiding this comment.
As you have the nonZeroVoxelIndices array why you are not using it here, instead of using the pointInShapeCallback? In case of a CT mask in a PET you are calculationg for each CT voxel, that could be a very large number, lots of calculations that doens need to be done
There was a problem hiding this comment.
Good point. because I need the segPointLPS of each of the masks voxels, and also I have an early return in the first line of callback. My benchmark don't show any performance issue, but I added a todo
Context
when we use the mask to grab the information from a reference volume, if they are not the same properties (spacing, direction, etc.) we should consider the voxel overlaps and average (maybe we re-configure this later or maybe do weighted average based on the overlap percentage)
Changes & Results
calculates the voxel overlaps
Testing
Checklist
PR
semantic-release format and guidelines.
Code
[] My code has been well-documented (function documentation, inline comments,
etc.)
[] I have run the
yarn build:update-apito update the API documentation, and havecommitted the changes to this PR. (Read more here https://www.cornerstonejs.org/docs/contribute/update-api)
Public Documentation Updates
additions or removals.
Tested Environment