Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stackSync): Don't throw NPE if options is empty #795 #799

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

wayfarer3130
Copy link
Collaborator

Context

The stack image sync changes added a reference to options that didn't use ?. so it was throwing a NPE if options wasn't set.

Changes & Results

Testing

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] "OS:
  • [] "Node version:
  • [] "Browser:

@netlify
Copy link

netlify bot commented Sep 25, 2023

Deploy Preview for cornerstone-3d-docs ready!

Name Link
🔨 Latest commit e47518d
🔍 Latest deploy log https://app.netlify.com/sites/cornerstone-3d-docs/deploys/6511a9dce272ca0008c2344c
😎 Deploy Preview https://deploy-preview-799--cornerstone-3d-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@wayfarer3130 wayfarer3130 changed the title fix(stackSync): Don't throw NPE if options is empty fix(stackSync): Don't throw NPE if options is empty #795 Sep 25, 2023
@sedghi sedghi merged commit bd3d5c9 into main Sep 25, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants