Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(brush size): brush size should be calculated in world not in canvas #771

Merged
merged 10 commits into from
Sep 6, 2023

Conversation

sedghi
Copy link
Member

@sedghi sedghi commented Sep 5, 2023

Context

Segmentation Export
Make the generateSegmentation function to return the segmentation dataset instead of the arraybuffer since one might need to push it to the server

Brush Tool
Previously the brush tool modifications/interaction were updating the scalarData and triggering the segmentaion_data_modified A LOT, which is not performance optimized and later when we add the history undo/redo we will end up with problems (since each transaction should be undo/redoable not the whole drag). This PR will show an intermediate step showing the brush locations (similar to volview and 3D Slicer) and when the mouse up happens it does the scalar data update, we call this lazyCalculation

Brush Tool size
Previously the brush tool size was in canvas, which means that when you zoomed in the image the brush size would become smaller which is unexpected by the user. This PR changes it to the world coordinates in mm units

Changes & Results

Testing

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] "OS:
  • [] "Node version:
  • [] "Browser:

@netlify
Copy link

netlify bot commented Sep 5, 2023

Deploy Preview for cornerstone-3d-docs ready!

Name Link
🔨 Latest commit e60a00b
🔍 Latest deploy log https://app.netlify.com/sites/cornerstone-3d-docs/deploys/64f88b2d982d3a00079e26d6
😎 Deploy Preview https://deploy-preview-771--cornerstone-3d-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sedghi sedghi changed the title fix/segmetation export fix(brush size): brush size should be calculated in world not in canvas Sep 5, 2023
@sedghi sedghi requested a review from jbocce September 6, 2023 01:25
Copy link
Contributor

@jbocce jbocce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor comments.

@sedghi sedghi merged commit 6ca1e3a into main Sep 6, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants